IOktaClient.GetCollection<T> returns an ICollectionClient<T> - Githubissues

okta / okta-sdk-dotnet

A .NET SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.

Other

160 stars 100 forks source link

IOktaClient.GetCollection<T> returns an ICollectionClient<T> #582

Closed danverde closed 2 years ago

danverde commented 2 years ago

Summary

Update both overloads of IOktaClient.GetCollection<T> to return an ICollectionClient<T> rather than a CollectionClient<T>.

Fixes #581

Type of PR

[ ] Bug Fix (non-breaking fixes to existing functionality)
[ ] New Feature (non-breaking changes that add new functionality)
[ ] Documentation update
[ ] Test Updates
[X] Other (Obvious Fix)

.NET Version: Os Version:

Signoff

[X] I have submitted a CLA for this PR (skipped as I believe this to be an obvious fix)
[X] Each commit message explains what the commit does
[ ] I have updated documentation to explain what my PR does
[ ] My code is covered by tests if required
[ ] I checked StyleCop warnings on my code

laura-rodriguez commented 2 years ago

Hi, @danverde,

Thank you for helping us to make our SDK better!

We're close to releasing a major version of the SDK which adds support for OASv3. We'll consider your request for the next version and adjust it to the new SDK patterns.