Add support for string enums - Githubissues

okta / okta-sdk-dotnet

A .NET SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.

Other

160 stars 100 forks source link

Add support for string enums #592

Closed laura-rodriguez closed 2 years ago

laura-rodriguez commented 2 years ago

Summary

Update templates to generate enums as StringEnums
Use the version of the spec that contains enums
Update UTs and ITs

Note: This is a massive PR because the templates have been modified. For reviewers, I suggest looking at ITs and UTs and how they were affected by this huge change.

Fixes OKTA-537372

Type of PR

[ ] Bug Fix (non-breaking fixes to existing functionality)
[x] New Feature (non-breaking changes that add new functionality)
[ ] Documentation update
[ ] Test Updates
[ ] Other (Please describe the type)

Test Information

[x] My PR required test updates

.NET Version: Os Version:

Signoff

[ ] I have submitted a CLA for this PR
[ ] Each commit message explains what the commit does
[ ] I have updated documentation to explain what my PR does
[ ] My code is covered by tests if required
[ ] I checked StyleCop warnings on my code

bryanapellanes-okta commented 2 years ago

This change is massive. What approach should I take when reviewing, what should I focus on?

laura-rodriguez commented 2 years ago

This change is massive. What approach should I take when reviewing, what should I focus on?

@bryanapellanes-okta As I mention in the summary, you should review the integration tests. Thanks!