search

okta / okta-sdk-dotnet

A .NET SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.
Other
160 stars 100 forks source link

Update UserType.cs #660

Closed dgarcia-hb closed 1 year ago

dgarcia-hb commented 1 year ago

Fix bug to be able to create a user with a non-default UserType by specifying the "Id" for User Type in Okta.Sdk.Model.CreateUserRequest

Summary

We, at HaynesBoone, need a way to dynamically add new users to Okta with the ability to assign a specific user type and as we could use the API ""/api/v1/users" to do so, it is in our best interest to use the Okta SDK. However there has been a recent update to the UserType Model that has set the property Id to private which now is preventing the UserType from being added.

Fixes # N/A

Type of PR

Test Information

.NET Version: .NET 7.0 Os Version:

Signoff

laura-rodriguez commented 1 year ago

Hi @dgarcia-hb,

Thanks for submitting this PR.

This SDK is generated using the Okta management OpenAPI specification, so if a change in the model/APIs is needed, we have to verify with the API teams if the change is appropriate and then update the spec and regenerate the SDK. You can check out our OpenAPI spec here. That being said, what version of the SDK you're using? We've recently updated the spec (v7.0.0), and there've been changes in the way you create users and specify the userType. Please take a look at the CreateUserRquest schema, which exposes a UserType property here. Also, check out our integration test that covers this matter here.

If your issue is still valid, please provide a sample code of what you're trying to achieve.

I hope this helps.

dgarcia-hb commented 1 year ago

First, thank you for looking over my PR.

We have just recently updated our Okta SDK from “5.6.2” to “7.0.0” which caused some breaking changes. After all the changes were accounted for I noticed an error with the “CreateUserRequest” object where before version 7.0.0, so in the version “5.6.2”, I was able to instantiate a new object “UserType” and set the property “Id” to an environment variable to create a new user with a specific User Type using the “CreateUserAsync()” method. I cannot do this now because the property on UserType is private as before it was public. ☹ Can you please fix this?

@.***

@.***

Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 2:04 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.***> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660)

EXTERNAL: Sent from outside Haynes and Boone, LLP

Hi @dgarcia-hbhttps://urldefense.com/v3/__https:/github.com/dgarcia-hb__;!!KzIVK9q-m3Ij!IefHX7HDwAqRpVCChu7-x605a6Kus2YVL5FCiUfTo_BtBv95tOhCHUugxXZnzR4W25Vrv0-YLwCjsM3lZpH3mdQrkUFnDz4$,

Thanks for submitting this PR.

This SDK is generated using the Okta management OpenAPI specification, so if a change in the model/APIs is needed, we have to verify with the API teams if the change is appropriate and then update the spec and regenerate the SDK. You can check out our OpenAPI spec herehttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/blob/master/openapi3/management.yaml__;!!KzIVK9q-m3Ij!IefHX7HDwAqRpVCChu7-x605a6Kus2YVL5FCiUfTo_BtBv95tOhCHUugxXZnzR4W25Vrv0-YLwCjsM3lZpH3mdQrEp7y-dM$. That being said, what version of the SDK you're using? We've recently updated the spec (v7.0.0), and there've been changes in the way you create users and specify the userType. Please take a look at the CreateUserRquest schema, which exposes a UserType property herehttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/blob/master/openapi3/management.yaml*L24259__;Iw!!KzIVK9q-m3Ij!IefHX7HDwAqRpVCChu7-x605a6Kus2YVL5FCiUfTo_BtBv95tOhCHUugxXZnzR4W25Vrv0-YLwCjsM3lZpH3mdQrggrUCIg$. Also, check out our integration test that covers this matter herehttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/blob/master/src/Okta.Sdk.IntegrationTest/UserScenarios.cs*L407__;Iw!!KzIVK9q-m3Ij!IefHX7HDwAqRpVCChu7-x605a6Kus2YVL5FCiUfTo_BtBv95tOhCHUugxXZnzR4W25Vrv0-YLwCjsM3lZpH3mdQr3yRB4hM$.

If your issue is still valid, please provide a sample code of what you're trying to achieve.

I hope this helps.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696221681__;Iw!!KzIVK9q-m3Ij!IefHX7HDwAqRpVCChu7-x605a6Kus2YVL5FCiUfTo_BtBv95tOhCHUugxXZnzR4W25Vrv0-YLwCjsM3lZpH3mdQrWusHg8w$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BTTHEKWU5WAZ3WFTMTXXTTR3ANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!IefHX7HDwAqRpVCChu7-x605a6Kus2YVL5FCiUfTo_BtBv95tOhCHUugxXZnzR4W25Vrv0-YLwCjsM3lZpH3mdQrk1W1R94$. You are receiving this because you were mentioned.Message ID: @.**@.>>

CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

laura-rodriguez commented 1 year ago

Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?:

 var createUserRequest = new CreateUserRequest
            {
                Profile = new UserProfile
                {
                    FirstName = "John",
                    LastName = nameof(UpdateUserUserType),
                    Email = $"john-{nameof(UpdateUserUserType)}-dotnet-sdk-{guid}@example.com",
                    Login = $"john-{nameof(UpdateUserUserType)}-dotnet-sdk-{guid}@example.com",
                    NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}",
                },
                Credentials = new UserCredentials
                {
                    Password = new PasswordCredential
                    {
                        Value = "foo"
                    }
                },
               Type = myUserType, // Assigning specific user type here so I create a user with the desired user type
            };

             var createdUser = await _userApi.CreateUserAsync(createUserRequest);
dgarcia-hb commented 1 year ago

According to the documentation it is suppose to be like this:

var createUserRequest = new CreateUserRequest

        {

            Profile = new UserProfile

            {

                FirstName = "John",

                LastName = nameof(UpdateUserUserType),

                Email = ***@***.******@***.***>",

                Login = ***@***.******@***.***>",

                NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}",

            },

            Credentials = new UserCredentials

            {

                Password = new PasswordCredential

                {

                    Value = "foo"

                }

            },

           Type = new UserType

           {

                   Id = “123456790”

           }, // Assigning specific user type here so I create a user with the desired user type

        };

         var createdUser = await _userApi.CreateUserAsync(createUserRequest);

but again the property Id in UserType is private only, and before the update to 7.0.0 it was public.

@.***

Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.***> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660)

EXTERNAL: Sent from outside Haynes and Boone, LLP

Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?:

var createUserRequest = new CreateUserRequest

        {

            Profile = new UserProfile

            {

                FirstName = "John",

                LastName = nameof(UpdateUserUserType),

                Email = ***@***.******@***.***>",

                Login = ***@***.******@***.***>",

                NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}",

            },

            Credentials = new UserCredentials

            {

                Password = new PasswordCredential

                {

                    Value = "foo"

                }

            },

           Type = myUserType, // Assigning specific user type here so I create a user with the desired user type

        };

         var createdUser = await _userApi.CreateUserAsync(createUserRequest);

         ```

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$. You are receiving this because you were mentioned.Message ID: @.**@.>>

CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

dgarcia-hb commented 1 year ago

Totally wrong place to ask this but are you Laura Rodriguez from .NET CONF 2022?

@.***

Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.***> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660)

EXTERNAL: Sent from outside Haynes and Boone, LLP

Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?:

var createUserRequest = new CreateUserRequest

        {

            Profile = new UserProfile

            {

                FirstName = "John",

                LastName = nameof(UpdateUserUserType),

                Email = ***@***.******@***.***>",

                Login = ***@***.******@***.***>",

                NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}",

            },

            Credentials = new UserCredentials

            {

                Password = new PasswordCredential

                {

                    Value = "foo"

                }

            },

           Type = myUserType, // Assigning specific user type here so I create a user with the desired user type

        };

         var createdUser = await _userApi.CreateUserAsync(createUserRequest);

         ```

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$. You are receiving this because you were mentioned.Message ID: @.**@.>>

CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

laura-rodriguez commented 1 year ago

According to the documentation it is suppose to be like this: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.**@.>", Login = @.**@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = new UserType { Id = “123456790” }, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); but again the property Id in UserType is private only, and before the update to 7.0.0 it was public. @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660) EXTERNAL: Sent from outside Haynes and Boone, LLP Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.**@.>", Login = @.**@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = myUserType, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); ``` — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$>, or unsubscribe<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$>. You are receiving this because you were mentioned.Message ID: @.**@.>> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

Oh I see. Can you get the user type first and assign it to the user.Type property? I know this is an extra API call and not ideal, but at least that will unblock you until I discuss it with the API team.

I'll file an internal ticket to be reviewed and prioritized by the team.

Internal Ref: OKTA-642757

Thank you!

laura-rodriguez commented 1 year ago

Totally wrong place to ask this but are you Laura Rodriguez from .NET CONF 2022? @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660) EXTERNAL: Sent from outside Haynes and Boone, LLP Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.**@.>", Login = @.**@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = myUserType, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); ``` — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$>, or unsubscribe<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$>. You are receiving this because you were mentioned.Message ID: @.**@.>> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

😅 It depends, did you like the talk? If so, yes I talked about generating SDKs with OpenAPI.

dgarcia-hb commented 1 year ago

Yes, that is one of the things I tried and that does not work ☹, because I was willing to use that as a work around.

@.***

Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Tuesday, August 29, 2023 11:12 AM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.***> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660)

EXTERNAL: Sent from outside Haynes and Boone, LLP

According to the documentation it is suppose to be like this: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = new UserType { Id = “123456790” }, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); but again the property Id in UserType is private only, and before the update to 7.0.0 it was public. @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660__;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8ehvFYgY$) EXTERNAL: Sent from outside Haynes and Boone, LLP Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = myUserType, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); ``` — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$<https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM%24>, or unsubscribehttps://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc%24>. You are receiving this because you were mentioned.Message ID: @.@.>> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

Oh I see. Can you get the user type first and assign it to the user.Type property? I know this is an extra API call and not ideal, but at least that will unblock you until I discuss it with the API team.

I'll file an internal ticket to be reviewed and prioritized by the team.

Internal Ref: OKTA-642757https://urldefense.com/v3/__https:/oktainc.atlassian.net/browse/OKTA-642757__;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8Ovj3q-Q$

Thank you!

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1697755954__;Iw!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8z6QIW0M$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BV7HICF6EDNJHATN2TXXYIGXANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR83KYFO9k$. You are receiving this because you were mentioned.Message ID: @.***>

CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

dgarcia-hb commented 1 year ago

LOL! I’m geeking out a little 😊. Small world! I loved your presentation and watched it this morning because coincidence we are trying to build our SDK’s with Swagger Hub and I was looking around to see how some people implemented OpenAPI. I will be sure to follow your github 👍

Thank you for everything!

@.***

Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Tuesday, August 29, 2023 11:15 AM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.***> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660)

EXTERNAL: Sent from outside Haynes and Boone, LLP

Totally wrong place to ask this but are you Laura Rodriguez from .NET CONF 2022? @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660__;!!KzIVK9q-m3Ij!JdnZdXmAhsUKDueRGdpVf_aFfTkYBw-d2gYJU6V5UF2tCTVl-OhchRL7hSfsv1ljisV8mIl4TRPlNzwHC8RLr_8vcaFunLI$) EXTERNAL: Sent from outside Haynes and Boone, LLP Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = myUserType, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); ``` — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$<https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM%24>, or unsubscribehttps://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc%24>. You are receiving this because you were mentioned.Message ID: @.@.>> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

😅 It depends, did you like the talk? If so, yes I talked about generating SDKs with OpenAPI.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1697760048__;Iw!!KzIVK9q-m3Ij!JdnZdXmAhsUKDueRGdpVf_aFfTkYBw-d2gYJU6V5UF2tCTVl-OhchRL7hSfsv1ljisV8mIl4TRPlNzwHC8RLr_8vagOX9hk$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BTO2KZDFYOLI3M2EW3XXYIQ3ANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!JdnZdXmAhsUKDueRGdpVf_aFfTkYBw-d2gYJU6V5UF2tCTVl-OhchRL7hSfsv1ljisV8mIl4TRPlNzwHC8RLr_8vwqNbIiY$. You are receiving this because you were mentioned.Message ID: @.***>

CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

laura-rodriguez commented 1 year ago

Yes, that is one of the things I tried and that does not work ☹, because I was willing to use that as a work around. @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Tuesday, August 29, 2023 11:12 AM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660) EXTERNAL: Sent from outside Haynes and Boone, LLP According to the documentation it is suppose to be like this: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = new UserType { Id = “123456790” }, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); but again the property Id in UserType is private only, and before the update to 7.0.0 it was public. @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660<https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8ehvFYgY$>) EXTERNAL: Sent from outside Haynes and Boone, LLP Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = myUserType, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); ``` — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$<https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM%24>>, or unsubscribe<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc%24>>. You are receiving this because you were mentioned.Message ID: @.@.>> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system. Oh I see. Can you get the user type first and assign it to the user.Type property? I know this is an extra API call and not ideal, but at least that will unblock you until I discuss it with the API team. I'll file an internal ticket to be reviewed and prioritized by the team. Internal Ref: OKTA-642757<https://urldefense.com/v3/https:/oktainc.atlassian.net/browse/OKTA-642757;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8Ovj3q-Q$> Thank you! — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1697755954;Iw!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8z6QIW0M$>, or unsubscribe<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BV7HICF6EDNJHATN2TXXYIGXANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR83KYFO9k$>. You are receiving this because you were mentioned.Message ID: @.***> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

Then the workaround would be creating a user, and calling partialUpdate right after. I know this works because we have a test here. Again, this is not ideal, but a workaround in the meantime.

dgarcia-hb commented 1 year ago

Laura, I really appreciate you trying to find a temporary solution and for the one you provided that does not assign the UserType to the User. As you can see on line 444 from the code that you provided the code has been commented out probably because it does not work.

            createdUser = await _userApi.CreateUserAsync(createUserRequest);

            createdUserType = await _userTypeApi.CreateUserTypeAsync(
                new UserType
                {
                    Name = nameof(UpdateUserUserType),
                    DisplayName = nameof(UpdateUserUserType),
                });

            //createdUser.Type.Id = createdUserType.Id;

            var updatedUser = await _userApi.ReplaceUserAsync(createdUser.Id, createdUser);

            updatedUser = await _userApi.GetUserAsync(createdUser.Id);

            updatedUser.Type.Id.Should().Be(createdUserType.Id);

I have temporarily resolved this issue by creating a local extension in my implementation that uses the exact same signature as Okta but I customized it to have a model that I declared that allows UserType.Id to be passed in. As the solution I created is a great workaround I would very much just like to stick to using the Okta SDK in hopes that it would make my life simpler 😊

Thank you,

@.***

Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Tuesday, August 29, 2023 12:11 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.***> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660)

EXTERNAL: Sent from outside Haynes and Boone, LLP

Yes, that is one of the things I tried and that does not work ☹, because I was willing to use that as a work around. @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Tuesday, August 29, 2023 11:12 AM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660__;!!KzIVK9q-m3Ij!NS4VRkZOdKyajijLQ14Fonl1BkRiWxznWhHqPoJJl33nEqxhoHHbZkxpMxEgAKg7UzeC6GqqCHB65bVvzonFN3gt2fcL7z4$) EXTERNAL: Sent from outside Haynes and Boone, LLP According to the documentation it is suppose to be like this: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = new UserType { Id = “123456790” }, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); but again the property Id in UserType is private only, and before the update to 7.0.0 it was public. @. Dennis Garcia | Application Developer | He/Him/His @. | (t) +1 972.275.8148 From: Laura Rodríguez @.> Sent: Monday, August 28, 2023 4:16 PM To: okta/okta-sdk-dotnet @.> Cc: Garcia, Dennis @.>; Mention @.> Subject: Re: [okta/okta-sdk-dotnet] Update UserType.cs (PR #660https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660__;!!KzIVK9q-m3Ij!NS4VRkZOdKyajijLQ14Fonl1BkRiWxznWhHqPoJJl33nEqxhoHHbZkxpMxEgAKg7UzeC6GqqCHB65bVvzonFN3gt2fcL7z4$https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8ehvFYgY$<https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660__;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8ehvFYgY%24>) EXTERNAL: Sent from outside Haynes and Boone, LLP Thanks for your response. I'll file an internal ticket to review and fix the issue accordingly, but can you please confirm if what you are trying to do is something like the following?: var createUserRequest = new CreateUserRequest { Profile = new UserProfile { FirstName = "John", LastName = nameof(UpdateUserUserType), Email = @.@.>", Login = @.@.>", NickName = $"johny-{nameof(UpdateUserUserType)}-{guid}", }, Credentials = new UserCredentials { Password = new PasswordCredential { Value = "foo" } }, Type = myUserType, // Assigning specific user type here so I create a user with the desired user type }; var createdUser = await _userApi.CreateUserAsync(createUserRequest); ``` — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM$<https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM%24<https://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM%24%3Chttps:/urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1696422093__;Iw!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk64JvhoKzM%24>>, or unsubscribehttps://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc$<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc%24<https://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc%24%3Chttps:/urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BU34Q77CTTBTP25XE3XXUDAJANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!JxhMBmQ5nK_8qqasCd4MbAmsxVRLsQ_ao1mNYebwPyT3V-oi3_hxkhIRmMwiYgyYcihbKY-oHCDO5V5IY86Bmk648r7Eivc%24>>. You are receiving this because you were mentioned.Message ID: @.@.>> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system. Oh I see. Can you get the user type first and assign it to the user.Type property? I know this is an extra API call and not ideal, but at least that will unblock you until I discuss it with the API team. I'll file an internal ticket to be reviewed and prioritized by the team. Internal Ref: OKTA-642757https://urldefense.com/v3/https:/oktainc.atlassian.net/browse/OKTA-642757;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8Ovj3q-Q$<https://urldefense.com/v3/__https:/oktainc.atlassian.net/browse/OKTA-642757__;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8Ovj3q-Q%24> Thank you! — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1697755954;Iw!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8z6QIW0M$<https://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1697755954__;Iw!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR8z6QIW0M%24>, or unsubscribehttps://urldefense.com/v3/https:/github.com/notifications/unsubscribe-auth/AJHI6BV7HICF6EDNJHATN2TXXYIGXANCNFSM6AAAAAA35BNGXA;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR83KYFO9k$<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BV7HICF6EDNJHATN2TXXYIGXANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!LDrdw767xF-ZhkoEe3rSlMrBQ8CBGopWcNgDoGgVWdToSNxoMkDfUfslL2FrZokpS9wi-0GC6ddCcta6gy9J-TR83KYFO9k%24>. You are receiving this because you were mentioned.Message ID: @.***> CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

Then the workaround would be creating a user, and calling partialUpdate right after. I know this works because we have a test herehttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/blob/master/src/Okta.Sdk.IntegrationTest/UserScenarios.cs*L407__;Iw!!KzIVK9q-m3Ij!NS4VRkZOdKyajijLQ14Fonl1BkRiWxznWhHqPoJJl33nEqxhoHHbZkxpMxEgAKg7UzeC6GqqCHB65bVvzonFN3gtIby6aso$. Again, this is not ideal, but a workaround in the meantime.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/okta/okta-sdk-dotnet/pull/660*issuecomment-1697838362__;Iw!!KzIVK9q-m3Ij!NS4VRkZOdKyajijLQ14Fonl1BkRiWxznWhHqPoJJl33nEqxhoHHbZkxpMxEgAKg7UzeC6GqqCHB65bVvzonFN3gtvEJOWoQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AJHI6BTHQZLGNQHZSQTZ5CTXXYPDVANCNFSM6AAAAAA35BNGXA__;!!KzIVK9q-m3Ij!NS4VRkZOdKyajijLQ14Fonl1BkRiWxznWhHqPoJJl33nEqxhoHHbZkxpMxEgAKg7UzeC6GqqCHB65bVvzonFN3gtsBVQ6JY$. You are receiving this because you were mentioned.Message ID: @.**@.>>

CONFIDENTIALITY NOTICE: This electronic mail transmission is confidential, may be privileged and should be read or retained only by the intended recipient. If you have received this transmission in error, please immediately notify the sender and delete it from your system.

jcaldwell-tandemdiabetes commented 1 year ago

@laura-rodriguez, TNDM is also impacted by this recent change in 7.0.0, since we have use cases that require modification of a federated user's UserType. We're unable to upgrade to 7.X from 6.0.X because of this new constraint. We configure the usertype okta identifiers -- which never change after we terraform the okta env -- and we don't want to add more latency to the use case by querying the user type. I suppose one option is to query and cache the user types, but we already deploy these values with the service.

jcaldwell-tandemdiabetes commented 1 year ago

@dgarcia-hb thanks for reporting and submitting this!

dgarcia-hb commented 1 year ago

Out of curiosity about how long do these changes take to make into production?

laura-rodriguez commented 1 year ago

Hi @dgarcia-hb,

The team is currently focused on other priorities, but I'll put this issue on our radar during our next planning. Thanks for your patience.

laura-rodriguez commented 1 year ago

Superseded by #669