wip: add `JWT` as possible `AuthorizationMode`

ericnorris commented 2 years ago

Summary

This is a proof-of-concept PR in order to start a discussion around allowing users to specify pre-signed JWTs in the SDK, with the end goal being for it to be possible to use pre-signed JWTs in the Okta Terraform provider.

~I will update this description with a link to the matching PR in the Terraform provider once I have submitted it.~ See https://github.com/okta/terraform-provider-okta/pull/1237.

As a reminder for context: we'd like to explore using the Okta Terraform provider in an environment where the private key is opaque to us, that is, we have a mechanism for signing JWTs with some private key, but we don't know the actual value of the private key, and so we cannot configure the provider (nor the SDK) with the private key directly.

The change to the SDK is relatively minor; instead of always generating the JWT the code can now optionally use the WithToken configuration option as the JWT. I'm not tied to the exact implementation below, and would be open to a new configuration option, etc.

Type of PR

[ ] Bug Fix (non-breaking fixes to existing functionality)
[x] New Feature (non-breaking changes that add new functionality)
[ ] Documentation update
[ ] Test Updates
[ ] Other (Please describe the type)

Test Information

There are no tests for this as it is a proof-of-concept, but I would absolutely add tests in order to get this merged.

Signoff

[ ] I have submitted a CLA for this PR
[x] Each commit message explains what the commit does
[ ] I have updated documentation to explain what my PR does
[ ] My code is covered by tests if required
[ ] I ran make fmt on my code
[ ] I did not edit any automatically generated files

monde commented 2 years ago

As the API supports this, the SDK should as well. We need to write some tests around this PR and as well as explanation and usage documentation in the README.

github-actions[bot] commented 2 years ago

This PR has been marked stale because there has been no activity within the last 28 days. To keep this PR active, remove the stale label.

duytiennguyen-okta commented 10 months ago

This is now supported in v3

okta / okta-sdk-golang