okta / okta-sdk-golang

A Golang SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.
https://github.com/okta/okta-sdk-golang
Other
171 stars 142 forks source link

feat: Avoid hitting rate limits by looking at `X-Rate-Limit-*` headers #434

Open erezrokah opened 4 months ago

erezrokah commented 4 months ago

Describe the feature request?

Implement the best practices from https://developer.okta.com/docs/reference/rl-best-practices/#example-rate-limit-header-with-org-wide-rate-limit to avoid hitting rate limits, and also wait until the limit reset time instead of a retry/backoff mechanism.

New or Affected Resource(s)

All existing and new resources will be affected I think

Provide a documentation link

https://developer.okta.com/docs/reference/rl-best-practices/#example-rate-limit-header-with-org-wide-rate-limit

Additional Information?

I'm aware of the existing backoff and retry configuration, it seems better practice to follow the headers returned from the server

tjpoe commented 4 months ago

agreed. we are hitting rate warnings on our instance and would love a way to throttle the speed of requests to stay within the api limitation.

github-actions[bot] commented 4 months ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 4 months ago

Not stale

github-actions[bot] commented 3 months ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 3 months ago

Not stale

github-actions[bot] commented 3 months ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 3 months ago

Not stale

erezrokah commented 3 months ago

Proposal at https://github.com/okta/okta-sdk-golang/pull/450, will wait for feedback before adding docs, tests and updating the template files that generate the code

github-actions[bot] commented 2 months ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 2 months ago

Not stale

github-actions[bot] commented 2 months ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 2 months ago

Not stale

github-actions[bot] commented 1 month ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 1 month ago

Not stale

github-actions[bot] commented 1 month ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 1 month ago

Not stale

github-actions[bot] commented 2 weeks ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 2 weeks ago

Not stale

github-actions[bot] commented 8 hours ago

This issue has been marked stale because there has been no activity within the last 14 days. To keep this issue active, remove the stale label.

erezrokah commented 5 hours ago

Not stale