add support for dpop - Githubissues

okta / okta-sdk-golang

A Golang SDK for interacting with the Okta management API, enabling server-side code to manage Okta users, groups, applications, and more.

https://github.com/okta/okta-sdk-golang

Other

171 stars 142 forks source link

add support for dpop #454

Closed duytiennguyen-okta closed 2 months ago

duytiennguyen-okta commented 2 months ago

Summary

Fixes #

Type of PR

[ ] Bug Fix (non-breaking fixes to existing functionality)
[x] New Feature (non-breaking changes that add new functionality)
[ ] Documentation update
[ ] Test Updates
[ ] Other (Please describe the type)

Test Information

[ ] My PR required test updates

Go Version: Os Version: OpenAPI Spec Version:

Signoff

[ ] I have submitted a CLA for this PR
[ ] Each commit message explains what the commit does
[ ] I have updated documentation to explain what my PR does
[ ] My code is covered by tests if required
[ ] I ran make fmt on my code
[ ] I did not edit any automatically generated files

duytiennguyen-okta commented 2 months ago

I see templates have been modified, but the actual client needs to be included to the PR? Also, make sure you're sending isDPoP: true (check tech design doc for user-agent details) via user-agent for tracking purposes. I agree we should update the readme with at least a note that the SDK supports DPoP?

I have added the user-agent header. In go, we only need to check in the template. The codegen will be done by github action