okta / okta-sdk-php

PHP SDK for the Okta API
Apache License 2.0
38 stars 71 forks source link

Make applicationGroupAssignment null by default. #134

Open bijanmmarkes opened 2 years ago

bijanmmarkes commented 2 years ago

Adjusting applicationGroupAssignment as optional field for the createApplicationGroupAssignment() function to match Official Okta API documentation.

Pull Request for issue #133

The latest version of this SDK currently requires the ApplicationGroupsAssignment:

Okta\Generated\Applications\ApplicationGroupAssignment

This would be okay, but the issue is that is causes PSR7 to throw an exception:

\PSR7\Stream.php:88 : First argument to Stream::create() must be a string, resource or StreamInterface.

The current Okta API documentation claims that ApplicationGroupsAssignment is not a required field, and even if we wanted to pass it as a parameter, the action would fail due to the error mentioned above.

okta_api_current_doc

I suggest making the ApplicationGroupAssignment an optional parameter, just as it is in the Okta Java SDK.

It could just be that i'm initializing it incorrectly, but there's no documentation and I've attempted various ways all with no success.

$appGroupAssignment = new ApplicationGroupAssignment();
$application->createApplicationGroupAssignment($group_id, $appGroupAssignment);

Result: First argument to Stream::create() must be a string, resource or StreamInterface.
simplifytransit commented 2 years ago

This is much needed! 👍

bretterer commented 2 years ago

Thank you for the PR. This will have to be adjusted in our openapi spec in order to update it here. We will llook at how we can improve this