search

okta / okta-sdk-php

PHP SDK for the Okta API
Apache License 2.0
38 stars 71 forks source link

WIP Changed some dependencies versions in order to support symfony 4.2.x #61

Closed kezek closed 5 years ago

kezek commented 5 years ago

As it stands we can't install this library on latest symfony stable (4.2.x). Some minor library changes can alleviate this issue.

le: not really , see my comment below :(

kezek commented 5 years ago

Well , this sucks:

  1. Tests pass with symfony/yaml 3.4. and tightenco/collect 5.6. and they don't have any dependency conflicts with symfony 4.2.*

  2. tightenco/collect 5.5.33 can't work with symfony 4.2.* due to locked dependecy symfony/var-dumper: ~3.3

  3. But tightenco/collect 5.6.* only supports php 7.1.3+ (as well as symfony 4.2)

So I guess this library won't work out-of-the-box with symfony 4.2 ?

@bretterer any suggestions on how to make this work ? Thanks

bretterer commented 5 years ago

The issue with this is tightenco/collect. I have that dep locked to 5.5.3 because 5.6 introduced breaking changes, not following semver. At this point, this will not work on symfony 4.2 I am not sure what the best route for this will be other than re-writing the collect client to do what we need.

I will put this on our log to address but not sure of the timeline for it.

kezek commented 5 years ago

I understand , thanks for your input. I'll use my fork until this gets sorted then.

Should I close this PR and create an issue or do you have any other preference ?

Thanks

bretterer commented 5 years ago

Go ahead and convert this over to a standard issue. Thanks!