okta / okta-sdk-php

PHP SDK for the Okta API
Apache License 2.0
38 stars 71 forks source link

Tests for Generated Models #8

Closed bretterer closed 7 years ago

bretterer commented 7 years ago

This PR writes tests for all generated models as well as makes fixes for code for the tests.

bretterer commented 7 years ago

Codecov Report

Merging #8 into develop will increase coverage by 58.58%. The diff coverage is 99.3%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop       #8       +/-   ##
==============================================
+ Coverage       40.8%   99.39%   +58.58%     
- Complexity       296      312       +16     
==============================================
  Files             35       33        -2     
  Lines            821      985      +164     
==============================================
+ Hits             335      979      +644     
+ Misses           486        6      -480
Impacted Files Coverage Δ Complexity Δ
src/Users/UserActivationToken.php 100% <ø> (ø) 2 <0> (?)
src/Users/ResetPasswordToken.php 100% <ø> (+100%) 1 <0> (ø) :arrow_down:
src/Okta.php 100% <100%> (+44.44%) 5 <0> (-1) :arrow_down:
src/GroupRules/GroupRuleUserCondition.php 100% <100%> (ø) 4 <2> (?)
src/GroupRules/GroupRuleConditions.php 100% <100%> (ø) 4 <4> (?)
src/Resource/AbstractResource.php 100% <100%> (+57.54%) 40 <1> (-6) :arrow_down:
src/GroupRules/GroupRulePeopleCondition.php 100% <100%> (ø) 4 <4> (?)
src/Users/TempPassword.php 100% <100%> (ø) 1 <1> (?)
src/GroupRules/GroupRuleGroupCondition.php 100% <100%> (ø) 4 <2> (?)
src/GroupRules/GroupRuleGroupAssignment.php 100% <100%> (ø) 2 <2> (?)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a222a95...00bfe2a. Read the comment docs.

bdemers commented 7 years ago

Sweet coverage update!