search

okta / okta-sdk-php

PHP SDK for the Okta API
Apache License 2.0
38 stars 71 forks source link

Support Symfony 5 #91

Closed Janicules closed 3 years ago

Janicules commented 3 years ago

Update the composer.json file to handle Symfony 5

bretterer commented 3 years ago

Thanks for the request and the PR. We are working on a new version of the SDK right now, so I will include this into v2.0

ajardin commented 3 years ago

Hello @bretterer, is there any ETA for the 2.0.0 release? 🙂

bretterer commented 3 years ago

I am not sure of the timeline for the release of 2.0, but things are being developed in the sdk_v2 branch that can be used.

ajardin commented 3 years ago

Thanks for your quick reply! I will take a look at this branch then. EDIT: I may be wrong, but even this branch does not support Symfony 5.

$ composer require okta/sdk:dev-sdk_v2
[...]

  Problem 1
    - Installation request for okta/sdk dev-sdk_v2 -> satisfiable by okta/sdk[dev-sdk_v2].
    - okta/sdk dev-sdk_v2 requires symfony/yaml ^3.2|^4.3 -> no matching package found.
bretterer commented 3 years ago

@ajardin ya, thats correct. It has not been updated yet for symfony 5. Give me about an hour and ill put an update for this as long as everything works

bretterer commented 3 years ago

@ajardin can you confirm if https://github.com/okta/okta-sdk-php/pull/104 helps your use case?

ajardin commented 3 years ago

I confirm that the installation on a Symfony 5.1 project is working.

bretterer commented 3 years ago

Resolved with #104