search

okta / okta-sdk-python

Apache License 2.0
229 stars 143 forks source link

Update saml_application_settings_sign_on.py #373

Open mdrdannyr opened 9 months ago

mdrdannyr commented 9 months ago

When reading from OKTA API, SAML Applications that have preconfigured attribution statements are stored within 'configuredAttributeStatements'.

This is currently not passed to the results var when using get_application

This fix updates the model so that the value is passed

mdrdannyr commented 9 months ago

To provide more context and details:

This is what direct API call to OKTA using postman shows:

image

This is what the library returns from the get_application call:

image

As can be seen the configuredAttributeStatements are missing.

OKTA docs show the following regarding this key:

image

Uncertain if the code is correct and stands up to your own guidelines. Happy to work with someone to get this merged in

mdrdannyr commented 9 months ago

closes #374

mdrdannyr commented 8 months ago

Hi

@bryanapellanes-okta @bretterer

Hope you're both doing well.

Tagging you as i see you guys are quite active in the latest commits to master. Could either of you help me out here in getting this relatively small fix into a release?