search

okta / okta-sdk-python

Apache License 2.0
229 stars 143 forks source link

Bug: "Okta direct auth API grants" are not valid OAuthGrantType #396

Open Interperle opened 2 months ago

Interperle commented 2 months ago

If there's an application that has one of the "Okta direct auth API grants" activated and you're trying to fetch it, you're getting the error, f'{GRANT_TYPE_NAME}' is not a valid OAuthGrantType.

That affects, especially the "list_applications" method.

To fix this the OAuthGrantType enum must be extended by: OTP = "urn:okta:params:oauth:grant-type:otp", "URN:OKTA:PARAMS:OAUTH:GRANT-TYPE:OTP" OOB = "urn:okta:params:oauth:grant-type:oob", "URN:OKTA:PARAMS:OAUTH:GRANT-TYPE:OOB" MFA_OTP = "http://auth0.com/oauth/grant-type/mfa-otp", "HTTP://AUTH0.COM/OAUTH/GRANT-TYPE/MFA-OTP" MFA_OOB = "http://auth0.com/oauth/grant-type/mfa-oob", "HTTP://AUTH0.COM/OAUTH/GRANT-TYPE/MFA-OOB"

Interperle commented 2 months ago

Already added Pull Request to fix this bug. Please review and merge as soon as possible before these Grant Types are deployed in Okta Prod.

blind-coder commented 1 month ago

Running into this as well, thanks for the PR, Interperle. Okta, please merge ASAP!

bryanapellanes-okta commented 1 month ago

@Interperle Thank you for reporting this! I've entered an internal ticker for tracking, and I will review the PR you've submitted to ensure no regressions are introduced.

OKTA-733531