okta / okta-signin-widget

HTML/CSS/JS widget that provides out-of-the-box authentication UX for your organization's apps
Other
375 stars 317 forks source link

Add Support for the V1 Widget to accept a codeChallenge parameter #2245

Open emanor-okta opened 3 years ago

emanor-okta commented 3 years ago

:information_source: If you have a question, please post it on the Okta Developer Forum instead. Issues in this repository are reserved for bug reports and feature requests.

I'm submitting a

Background info

The V1 Widget allows setting a codeChallenge option, but it is not used during a pkce flow. Update the V1 Widget to use the supplied value.

Expected behavior

The codeChallenge value supplied as an option to the Widget Config should be used in the pkce flow.

What went wrong?

The V1 Widget currently generates it own verifier/challenge even if a codeChallenge is provided.

Steps to reproduce

Supply a codeChallenge and codeChallengeMethod via the widget config. During /authorization the widget will generate its own verifier and challenge off of the verifier.

Your environment

emanor-okta commented 3 years ago

internal ref: OKTA-436189