okta / okta-signin-widget

HTML/CSS/JS widget that provides out-of-the-box authentication UX for your organization's apps
Other
376 stars 319 forks source link

Compiling an Angular 14 app with the Sign-In Widget results in lots of warnings #2714

Open mraible opened 2 years ago

mraible commented 2 years ago

Describe the bug

When you run ng serve on an Angular 14 app with the Sign-In Widget, there are lots of scary warnings on startup. These also show up in the browser console.

> ng serve

✔ Browser application bundle generation complete.

Initial Chunk Files   | Names         |   Raw Size
vendor.js             | vendor        |    7.99 MB |
polyfills.js          | polyfills     | 1016.40 kB |
styles.css, styles.js | styles        |  953.45 kB |
main.js               | main          |   48.60 kB |
runtime.js            | runtime       |    6.52 kB |

                      | Initial Total |    9.97 MB

Build at: 2022-08-16T16:25:59.780Z - Hash: 1d2411751197d836 - Time: 7562ms

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-auth-js/esm/browser/AuthStateManager.js depends on 'p-cancelable'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-auth-js/esm/browser/OktaAuth.js depends on 'tiny-emitter'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-auth-js/esm/browser/fetch/fetchRequest.js depends on 'cross-fetch'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-signin-widget/dist/esm/packages/@okta/courage-dist/esm/src/courage/util/Clipboard.js depends on 'clipboard'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-signin-widget/dist/esm/src/util/TimeUtil.js depends on '@sindresorhus/to-milliseconds'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-signin-widget/dist/esm/src/util/TimeUtil.js depends on 'parse-ms'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-signin-widget/dist/esm/src/v1/controllers/EnrollDuoController.js depends on 'q'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/@okta/okta-signin-widget/node_modules/@okta/okta-auth-js/esm/esm.browser.js depends on '@babel/runtime-corejs3/regenerator'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /Users/mraible/dev/okta-samples/okta-angular-sample/node_modules/unload/dist/es/index.js depends on 'detect-node'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **

✔ Compiled successfully.

What is expected to happen?

No warnings would be nice.

What is the actual behavior?

Lots of warnings.

Reproduction Steps

Install the Okta CLI and run the following command:

okta start angular --branch widget

Then, follow the instructions to start the app.

SDK Versions

"@okta/okta-angular": "^5.2.0",
"@okta/okta-auth-js": "^6.7.5",
"@okta/okta-signin-widget": "^6.6.1",

You can see the full package.json at https://github.com/okta-samples/okta-angular-sample/blob/widget/package.json.

Execution Environment

macOS Monterey Node.js v16.16.0

Additional Information?

No response

denysoblohin-okta commented 1 year ago

Third-party packages mentioned in these warnings still don't have ESM versions