Gen3: Use i18next instead of `loc` - Githubissues

okta / okta-signin-widget

HTML/CSS/JS widget that provides out-of-the-box authentication UX for your organization's apps

Other

376 stars 320 forks source link

Gen3: Use i18next instead of `loc` #3689

Open denysoblohin-okta opened 1 month ago

denysoblohin-okta commented 1 month ago

Description:

Use i18next library for Gen3 instead of Courage's loc function for pluralization support

Example: use

password.complexity.length.description_one = At least one character
password.complexity.length.description_other = At least {0} characters
# fallback (same as _other)
password.complexity.length.description = At least {0} characters

instead of single

password.complexity.length.description = At least {0} characters

PR Checklist

[x] Have you verified the basic functionality for this change?
[x] Did you add tests, as appropriate, following our Automated Test guidelines?
[ ] Did you follow our Security Best Practices?
[x] Did you verify the change by running downstream monolith artifact? (Provide link to build below)
[ ] Does this PR include noticeable changes to the UI? (If yes, attach screenshots/video below)

Issue:

OKTA-797066

Reviewers:

Screenshot/Video:

Downstream Monolith Build: