okta / okta-storage-swift

Secure storage library
https://github.com/okta/okta-storage-swift
Other
8 stars 8 forks source link

Treat macOS keychain like iOS keychain. #15

Closed arunthotta-okta closed 4 years ago

arunthotta-okta commented 4 years ago

Please see https://github.com/okta/okta-devices-swift/pull/57 for detailed description for a similar change.

arunthotta-okta commented 4 years ago

@IldarAbdullin-okta might need your help for the release steps.

IldarAbdullin-okta commented 4 years ago

@arunthotta-okta , there are compilation errors for test target. Could you please check?

arunthotta-okta commented 4 years ago

@IldarAbdullin-okta was able to get past the build errors if I bump up Xcode version https://docs.travis-ci.com/user/reference/osx/#macos-version. looking into some test failures now. seeing same failures locally. debugging now.

also first time dealing with travis :)

arunthotta-okta commented 4 years ago

weird because the changes should be a no-op for the iOS test scheme