search

okta / okta-storage-swift

Secure storage library
https://github.com/okta/okta-storage-swift
Other
8 stars 8 forks source link

OKTA-213467-Implement swift wrapper for keychain iOS API #4

Closed IldarAbdullin-okta closed 5 years ago

IldarAbdullin-okta commented 5 years ago

Problem Analysis (Technical)

Implement high level API for working with iOS keychain Add basic operations:

Solution (Technical)

Implement

Tests

Added

IldarAbdullin-okta commented 5 years ago

Very good job, Ildar. Looks clean. Only thing I concern is "behind biometrics". As I understand, when you try to get some value from keychain which is "behind biometrics", it will not happen instantly, because user will have to authenticate with finger/face. So, doesn't it block client application? If yes, we should make this api async.

This is very valid concern. Readme has the following statement regarding this: > * Note: iOS will show native Touch ID or Face ID message view in case of biometrics enabled storage. It means that function may be blocked and wait for the user's action.

Probably would be a good idea to add example how to use get for the item with biometrics attribute