okta / okta-vue

OIDC SDK for Vue
https://github.com/okta/okta-vue
Other
46 stars 26 forks source link

Type definition is augmenting incorrect module #144

Open richmason opened 1 month ago

richmason commented 1 month ago

Describe the bug

The src/types/index.ts file is augmenting @vue/runtime-core instead of vue. Please see the Vue docs for Augmenting Global Properties.

Also, please see the 4.4.1 patch release notes for vue-router that addresses this same issue, and warns that other packages will also need to update their code.

Reproduction Steps?

I am having the same problem as mentioned in this issue: https://github.com/intlify/vue-i18n/pull/1919#issuecomment-2294898187

The only sub-dependency that is still augmenting @vue/runtime-core instead of vue in my codebase is okta-vue.

SDK Versions

System:

Binaries:

Browsers:

npmPackages:

Additional Information

No response

jaredperreault-okta commented 1 month ago

Thanks for the report

Internal Ref: OKTA-805968