search

okta / samples-android

samples-android
https://github.com/okta/samples-android
Apache License 2.0
37 stars 52 forks source link

The browser is not closed on backPress of the activity #66

Open manishakalia opened 3 years ago

manishakalia commented 3 years ago

On using the WebAuthClient when I get the successful auth from okta and goes to another activity, on backpress of the new activity the browser still open thought the activity which was used for the auth has been removed but the browser is still open. I search in the issue the solution I tired adding eg:- android:launchMode="singleTop" tools:replace="android:launchMode"

But still the browser is open on backpress of new activity. Please guide if there any solution.

JayNewstrom commented 3 years ago

Hi @manishakalia Thanks for the issue. I'm able to recreate, and I've attached a screen recording of what's happening.

When clicking the Android back button on the bottom left of the screen, the page is refreshed, rather than exited. When clicking on the x on the top left of the screen, the page is properly dismissed.

https://user-images.githubusercontent.com/713288/116561942-5ea92100-a8c8-11eb-968e-c9e26ee0518f.mp4

I've created an internal ref: OKTA-391226 We will take a look and update you here with progress. Thanks!

manishakalia commented 3 years ago

Thank you for your response I am highlighting the point where we have 2 activity, one which call for auth to okta like above example you mentioned and another activity where it take after the access of auth from okta and we dismiss the first activity. As we have authenticate the user and fetch the information. But when I backpress from second activity, browser is still open where I can see the okta credentials being loading in the browser. It should be closed right!!. Its not closing the browser.

JayNewstrom commented 3 years ago

@manishakalia I think I'm following you, but I'm not sure. Would it be possible to upload a screen capture similar to the one I did above? Are you able to reproduce this in our sample app? Do you have example code if not?

JayNewstrom commented 3 years ago

Hi @manishakalia please reopen with more information. Thanks!

Naylet commented 2 years ago

Hi @manishakalia Thanks for the issue. I'm able to recreate, and I've attached a screen recording of what's happening.

When clicking the Android back button on the bottom left of the screen, the page is refreshed, rather than exited. When clicking on the x on the top left of the screen, the page is properly dismissed.

siw_bug.mp4 I've created an internal ref: OKTA-391226 We will take a look and update you here with progress. Thanks!

Hi @JayNewstrom! I'm facing the same issue on some devices. It seems that on Huawei everything works as expected and the user is redirected back to the previous activity. Unfortunatelly on Samsung the behaviour is the same as in the video you attached. Have you already found any solution for that?

JayNewstrom commented 2 years ago

Hi @Naylet could you give us more information about the devices you're seeing the issue on so we can reproduce it?

Naylet commented 2 years ago

@JayNewstrom I tested on : Samsung Galaxy J6 (Android 10) - not working Samsung A40 (Android 11) - not working Huawei P30 Pro (Android 10) - works as expected Huawei Mate 10 Lite (Android 8) - works as expected

JayNewstrom commented 2 years ago

@Naylet are you able to reproduce this in any Android Emulators?

Naylet commented 2 years ago

@JayNewstrom I tested on Pixel 3 and it's also not working. When clicking the back button the page is rather refreshed than closed.

Naylet commented 2 years ago

@JayNewstrom any updates? Were you able to reproduce it?

JayNewstrom commented 2 years ago

I don't have easy access to the mentioned devices. Have you been able to reproduce this on an Android emulator? That would be the easiest way for us to reproduce/fix it.

Naylet commented 2 years ago

@JayNewstrom I tested on : Samsung Galaxy J6 (Android 10) - not working Samsung A40 (Android 11) - not working Huawei P30 Pro (Android 10) - works as expected Huawei Mate 10 Lite (Android 8) - works as expected

@JayNewstrom I have to rectify . I tested few more times and it turned out that actually the device doesn't matter. The thing that triggers the issue is the focus. If the webView has no focus then we're able to go back on back button press. If we touch the screen and the webView gains focus then clicking on the back button will refresh the page - not close it.

Naylet commented 2 years ago

I don't have easy access to the mentioned devices. Have you been able to reproduce this on an Android emulator? That would be the easiest way for us to reproduce/fix it.

Pixel 3 is an Android Emulator that can be created in Android Studio. Also please have in mind that actually you already reproduced it in the video from 29th April 2021.

JayNewstrom commented 2 years ago

I've reopened the issue, and we'll take a look.

Naylet commented 2 years ago

@JayNewstrom what's the status?

Naylet commented 2 years ago

@JayNewstrom Please let me now if you could find any solution for the issue?