Update angular/cli to 1.6.8

sudobinbash commented 6 years ago

The version 1.6.1 has a issue with a missing @angular-devkit/core package.

https://github.com/angular/angular-cli/issues/9307

robertjd commented 6 years ago

Thanks @fhakamine !

Can you tell me what problem this was causing for you? I ask because we haven't seen any and I'd like to know how to reproduce.

I've also opened #7 with your commit so that our IT tests can run on the repo. The tests were failing with the update, and it appears to be because of this issue: https://github.com/angular/angular-cli/issues/8798#issuecomment-356262575

As such I've re-built the package lock files in that PR to remove our redundant webpack dependency.

Can you please give #7 a try and let me know if it still works for you?

sudobinbash commented 6 years ago

Thanks @fhakamine !

Can you tell me what problem this was causing for you?

I was getting this:

$ ng serve
module.js:471
    throw err;
    ^

Error: Cannot find module '@angular-devkit/core'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)

I ask because we haven't seen any and I'd like to know how to reproduce.

To reproduce:

Make sure you don't have @angular-devkit/core globally installed.
git clone https://github.com/okta/samples-js-angular.git && cd samples-js-angular/okta-hosted-login
npm i (installs @angular/cli, but does not include @angular-devkit/core)
ng serve (got the missing @angular-devkit/core issue)

I've also opened #7 with your commit so that our IT tests can run on the repo. The tests were failing with the update, and it appears to be because of this issue: angular/angular-cli#8798 (comment)

Cool :D

As such I've re-built the package lock files in that PR to remove our redundant webpack dependency.

Can you please give #7 a try and let me know if it still works for you?

I'll try to test this afternoon.

okta / samples-js-angular

Update angular/cli to 1.6.8 #6