search

okta / samples-js-react

React Auth SDK sample
Other
175 stars 260 forks source link

Update Home.jsx #162

Closed johnwargo closed 3 years ago

johnwargo commented 3 years ago

Because of the way the code was formatted, the "Welcome back, {user name}!" doesn't display a space between the comma and the user name (in the latest Chrome is displayed "Welcome back,John Wargo". So I pulled the code in so it spaces properly: "Welcome back, John Wargo".

swiftone commented 3 years ago

Thanks for the PR! We're currently fixing a bug in our CI system for this sample so it may be a short bit before we can merge this, but we appreciate your effort and will get this in.

johnwargo commented 3 years ago

@swiftone how's it coming with the build system?

mraible commented 3 years ago

@swiftone Any updates on this one?

shuowu-okta commented 3 years ago

Moved to #170 to pass the internal CI.