okta / samples-js-react

React Auth SDK sample
Other
174 stars 257 forks source link

SPA_CLIENT_ID reported as an error when CLIENT_ID is fine #271

Closed anselmhookcodex closed 2 years ago

anselmhookcodex commented 2 years ago

As far as I can tell vite.config.js has a test to see that SPA_CLIENT_ID is defined - however the application in reality looks for either CLIENT_ID or SPA_CLIENT_ID . Therefore it is incorrect to test that SPA_CLIENT_ID is always defined.

jaredperreault-okta commented 2 years ago

@anselmhookcodex Thanks for reporting, this should be fixed