search

okta / samples-js-vue

samples-js-vue
https://github.com/okta/samples-js-vue
Other
57 stars 63 forks source link

Update dependencies, fix vulnerabilities #74

Closed mraible closed 4 years ago

mraible commented 4 years ago

NOTE: I had to modify samples-nodejs-express-4/config.js for tests to pass locally.

@@ -14,7 +14,7 @@ if (fs.existsSync(TESTENV)) {
 var ISSUER = process.env.ISSUER || 'https://{yourOktaDomain}.com/oauth2/default';
 var CLIENT_ID = process.env.CLIENT_ID || '{clientId}';
 var CLIENT_SECRET = process.env.CLIENT_SECRET || '{clientSecret}';
-var SPA_CLIENT_ID = process.env.SPA_CLIENT_ID || '{spaClientId}';
+var SPA_CLIENT_ID = process.env.CLIENT_ID || '{spaClientId}';
 var OKTA_TESTING_DISABLEHTTPSCHECK = process.env.OKTA_TESTING_DISABLEHTTPSCHECK ? true : false;

 module.exports = {
mraible commented 4 years ago

I tried to upgrade these samples to use the latest version of Vue, but there are parser errors from eslint. I believe these can be fixed by using eslint-plugin-vue.

aarongranick-okta commented 4 years ago

@mraible Thanks! I will pull these changes into a branch and attempt the Vue update.

aarongranick-okta commented 4 years ago

New PR: https://github.com/okta/samples-js-vue/pull/83