search

oktetlabs / test-environment

OKTET Labs Test Environment
Other
5 stars 9 forks source link

lib/tapi_rpc: add readlink support #6

Closed okt-galaktionov closed 1 year ago

okt-galaktionov commented 1 year ago

This function is required to determine, for example, a network interface's BDF given its name. To do that, a symlink in sysfs has to be read.

Tested with a pending patch to net-drv-ts. This functionality is required there to determine the debug paths in sysfs.

okt-galaktionov commented 1 year ago

Yurij only reviewed the patch, he didn't write any part of it. I don't think he needs to sign it off.

As for testing done, I'm not sure there's anything else I can add to what the PR already says. This patch was used to successfully fix the basic/read_sysfs test in net-drv-ts. The fix is not in that repo yet. If you need any details, please tell me.

ol-arteman commented 1 year ago

Yurij only reviewed the patch, he didn't write any part of it. I don't think he needs to sign it off.

I know. But I suppose @ol-andrewr thinks otherwise. At least, in the previous case he insisted on having Signed-off-by by the formal commit author.

As for testing done, I'm not sure there's anything else I can add to what the PR already says. This patch was used to successfully fix the basic/read_sysfs test in net-drv-ts. The fix is not in that repo yet. If you need any details, please tell me.

Ok, I am satisfied.

okt-galaktionov commented 1 year ago

I don't understand what you mean by "formal commit author". Could you elaborate?

ol-arteman commented 1 year ago

I don't understand what you mean by "formal commit author". Could you elaborate? Ah, sorry. You are making this PR on your own behalf and you are the formal author, not Yurij. Case dismissed.