okteto / deploy-stack

GitHub action to deploy a stack in Okteto Cloud as part of your automated development workflow.
Apache License 2.0
7 stars 4 forks source link

Bug: Deploy-stack doesnt wait for a successfull deployment before exiting with a 0 system code #8

Closed vickywane closed 3 weeks ago

vickywane commented 3 years ago

I am currently using the Deploy stack actions to deploy my application stack to an Okteto namespace within a GitHub Action workflow.

After the stack is deployed, I have unit tests that make live HTTP tests against the deployed stack using the namespace URL. After several runs, I have discovered that the deploy-stack action does not fully wait for the deployment to be successful before exiting. This causes the action workflow to proceed to the next job which runs the API tests against an unready deployment.

To augment, I have employed the use of the nev7n/wait_for_response@v1 which waits for an extra 5s while pinging the deployment URL for a 200 status code to indicate a successful deployment.

Example failing GitHub Action run without nev7n/wait_for_response@v1

Example passing GitHub Action run withnev7n/wait_for_response@v1

pchico83 commented 3 years ago

@vickywane have you try with the pipeline action? https://github.com/marketplace/actions/okteto-pipeline

vickywane commented 3 years ago

No.

Would that be a better replacement for the deploy-stack action?

pchico83 commented 3 years ago

@vickywane https://github.com/marketplace/actions/okteto-pipeline The automatic pipeline will deploy your compose file: https://okteto.com/docs/cloud/okteto-pipeline/#automatic-deployment

rberrelleza commented 3 weeks ago

closing since action is now deprecated