search

okteto / docker-desktop-extension

Docker Extension for Okteto
Apache License 2.0
5 stars 4 forks source link

the 'stop' button doesn't stop okteto #13

Closed rberrelleza closed 2 years ago

rberrelleza commented 2 years ago

When I click stop, okteto is not stopped. If I then launch the same compose again, it fails to start because the port is taken.

rlamana commented 2 years ago

@pchico83 this is something that was going to get fixed with the latest okteto binary, right?

The alternative fix is that the docker extension API enabled a way to kill the launched process...

rberrelleza commented 2 years ago

Could be call 'okteto destroy' directly?

rlamana commented 2 years ago

@pchico83 wdty? Calling okteto destroy but with the -f to identify it? is this an option?

My other concern is when they leave the extension, we've seen that the extension gets restarted and there are no destructors or handlers on their API, which will leave the process hanging too...

pchico83 commented 2 years ago

The next okteto cli version will take care of killing the previous execution of okteto up, so you can go back in the extension and run again with no issue. I would go with that for now, destroying everything would make the next execution much slower

pchico83 commented 2 years ago

Also, I created an issue in the docker extension SDK to support the cancelation of a running command

rlamana commented 2 years ago

Just to properly track this, the issue that will allow the CLI to kill previous execution is being tracked here: https://github.com/okteto/okteto/issues/2294, right @pchico83 ?

pchico83 commented 2 years ago

@rlamana right

rlamana commented 2 years ago

So with https://github.com/okteto/okteto/issues/2294 the experience at least is fixed and launching it again won't fail. I'll remove this issue from the april-15th release.