okteto / docker-desktop-extension

Docker Extension for Okteto

Apache License 2.0

5 stars 4 forks source link

Added status property in UI #81

Closed aryabharat closed 9 months ago

aryabharat commented 1 year ago

Signed-off-by: aryabharat33 bharatarya33@gmail.com

Fixes Issue

74 && #75

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

rlamana commented 1 year ago

@aryabharat can you add screenshots of and a brief explanation of your solution?

aryabharat commented 1 year ago

Hi ! @rlamana

Status: for the status field just created a new function under okteto api, which fetches the status using okteto status command and called this function using setInterval with a pooling time of 3000 ms.

Screenshot from 2022-10-22 17-25-57

Toast notification: for this just used the status field as mentioned above and toast a success msg using the docker client. (let me know if the condition for the toast msg shd be improved)

Screenshot from 2022-10-22 19-21-10

toast condition:

   if (previousStatus && previousStatus === 'activating' && status === 'synchronizing' )
     window.ddClient.desktopUI.toast.success('env ready to use');
    if (!previousStatus || previousStatus !== status)
      setPreviousStatus(status)
    setStatus(status);

aryabharat commented 1 year ago

@rlamana update the PR, as requested. Please let me know if any improvements are required.

aryabharat commented 1 year ago

@rlamana I have updated the code as per your guidance. Please let me know if any other change is required.

aryabharat commented 1 year ago

Hi @rlamana any changes?

rlamana commented 1 year ago

@aryabharat We are still checking some issue with the ddClient.extension.host.cli.exec call that will get fixed upgrading to the latest @docker/extension-api-client. We are working on it. I'll get back to this PR as soon as everything is sorted out.

pchico83 commented 9 months ago

Closing this one due to inactivity. @aryabharat let us know if you are interested in updating the PR, we would need to follow a different approach to query the status

aryabharat commented 8 months ago

@pchico83 Thanks for the update. Please let me know what changes do you purpose, will be happy to do it.

aryabharat commented 8 months ago

@pchico83 @rlamana Please let me know the changes you want to be done. Will be happy for contribute.