okteto / pipeline

Enable GitHub developers to trigger Okteto Pipelines from a GitHub Actions workflow
https://okteto.com
Apache License 2.0
15 stars 8 forks source link

Show the error message why it has failed or at least show the pipeline URL just like running locally #17

Open kkweon opened 3 years ago

kkweon commented 3 years ago

I'm also seeing the same error message as in #14, but the thing is that error message doesn't help.

It simply says

failed to deploy pipeline: failed to deploy okteto pipeline

It doesn't say why it has failed.

image

Could it be perhaps updated to show an actual error message? Or show the pipeline URL just like running locally.

In my case, I can successfully run okteto pipeline deploy but in GitHub Actions, I get the error message and I'm still not sure what's going on (it used to work in the past months, and suddenly stopped working yesterday).

pchico83 commented 2 years ago

@kkweon could you try to set the name field of the github action. It should mandatory

kkweon commented 2 years ago

https://github.com/codingpot/pr12er/runs/3671096358?check_suite_focus=true

That was the first thing i tried but didn't work.

The name is not required unlike its description. I've been using without a name for several months already. That's another bug too.

pchico83 commented 2 years ago

In the logs it says:

okteto pipeline deploy --name push- '--branch=main'

I don't think it is getting the name parameter properly. Could you point to your github action?

kkweon commented 2 years ago

push- is the name

https://github.com/codingpot/pr12er/actions/runs/1260313992/workflow

      - uses: okteto/pipeline@master
        with:
          name: push-${{ github.event.number }}

it's just the event number didn't get propagated because i triggered manually.

pchico83 commented 2 years ago

Oh, I see. Did you try when it runs automatically? I think it is going to work

kkweon commented 2 years ago

I'm pretty positive that it wouldn't work. Could you explain ? name is set, and it didn't work.

kkweon commented 2 years ago

Just to be clear, the issue here is about an error message rather than debugging my issue (which will be resolved naturally if there's a clear error message).

pchico83 commented 2 years ago

push- is not a valid name. push-nnn is a valid name. that should unblock you. But yes, leave the issue opened, the error should be clearer

kkweon commented 2 years ago

thank you. it indeed resolve the issue.

is there a documentation on what a valid name is? if not, that would be the second feature request.

pchico83 commented 2 years ago

We will add it to the docs, but they have the same restrictions than kubernetes labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set