search

okteto / remote-kubernetes

Remote Kubernetes Development in VS Code with Okteto
Apache License 2.0
74 stars 15 forks source link

WIP add okteto icon to okteto.yml files #225

Open rberrelleza opened 1 year ago

rberrelleza commented 1 year ago

I wanted to distract myself and started playing with vscode integrations with languages and icons to see if we can add a custom icon of Okteto.

I got something working but I'm not super excited about it.

The icon on the file system looks a bit odd. Any suggestions on how to tinker with it? According to the docs, we need a 24x24 icon. I thought it would auto adjust the SVG file, but it might not be the case.

image

rberrelleza commented 1 year ago

Changing the icon makes vscode think of this as an 'okteto' language file, which removes the syntax coloring. I'll look for other ways to associate 'okteto.yml' files with our icon.

rlamana commented 1 year ago

Looking at one of the icons used in the example here in the docs https://code.visualstudio.com/api/extension-guides/file-icon-theme, it looks like they are using a 16x16 icon. Anyway, that's the viewbox definition of the svg, in theory being an svg it should be adjusted, the size it's just to define the proportions (https://github.com/microsoft/vscode/blob/main/extensions/theme-defaults/fileicons/images/folder-dark.svg?short_path=43d454e).

Looking at that icon, the viewbox is 16x16 but the icon actual size without the empty borders is 14x14. Here you have a version that does the same, let me know if this one works better:

vscode-okteto-icon https://user-images.githubusercontent.com/237819/229104589-4c1b769a-0100-46a5-ba9d-4c66b8e7d222.svg