search

okuda-seminar / Twitter-Clone

0 stars 0 forks source link

[go/users] Add default setting for is_private column #324

Closed katsurada1 closed 4 months ago

katsurada1 commented 4 months ago

Issue Number

303

Implementation Summary

Same with the title.

Scope of Impact

When a new user is created without is_private set.

Particular points to check

If there is anything else I should add.

Test

Nothing added.

Schedule

Anytime.

katsurada1 commented 4 months ago

@ryuju0911 When I tried to resolve the conflict, I could not get back to the original state, so I re-created a new branch and pull request. I will ask someone on Saturday how to resolve the conflict to avoid this procedure in the future.

I removed the is_private field from design's CreateUser method and instead set is_private to false by default when creating a user in the CreateUser function. Please review my code.