okuda-seminar / Twitter-Clone

0 stars 0 forks source link

[go/tweets] Change API entry-point of tweet service from tweets to posts #331

Closed summerive closed 4 months ago

summerive commented 4 months ago

Issue Number

289

Implementation Summary

Same with the title.

Scope of Impact

This change affects the API entry/end point of the tweet service.

Particular points to check

If something is wrong with my changes. I couldn't configure the original functionality after the change due to my docker malfunction.

Test

None.

Schedule

6/28(If possible.)

ryuji0123 commented 4 months ago

@summerive @ryuju0911 Can we divide this significantly huge commit into several ones? That should make it easy to develop, debug, and review.

ryuju0911 commented 4 months ago

@summerive Let's divide the commits based on the directory.

summerive commented 4 months ago

@ryuju0911 OK. I committed files in go/tweets and go/posts. Should we make other issues for renaming tasks?

summerive commented 4 months ago

@ryuju0911 Excuse me. I didn't understand what you meant. I've just separated the last commit into several ones.

ryuju0911 commented 4 months ago

@ryuji0123 @nayuta-ai Could you see if there is no problem in infra and swift directories?

summerive commented 4 months ago

I broke all the changes concerning the original issue. In this PR, I focused on making changes concerning the API entry point. Also, I changed the PR title according to the commit content.

ryuji0123 commented 4 months ago

You can explicitly say tweet is replaced with post in both commit and PR titles.

summerive commented 4 months ago

I see. I will change them.