okuda-seminar / Twitter-Clone

0 stars 0 forks source link

[CI/CD] Block pull requests if the PR title and commit messages do not meet the required standards #335

Closed nayuta-ai closed 4 months ago

nayuta-ai commented 4 months ago

Issue Number

319

Implementation Summary

We are implementing a feature to block pull requests if the PR title and commit messages do not meet the required standards as follows:

Scope of Impact

This implementation affects the process of creating a PR.

Particular points to check

Could you please verify if I haven't implemented any incorrect rules?

Test

https://github.com/okuda-seminar/Twitter-Clone/actions/runs/9724978425/job/26841773424

Schedule

7/6

nayuta-ai commented 4 months ago

@Rwatana Please review my code.

ryuji0123 commented 4 months ago

Thanks for working on this. Is it possible to accept this pattern also (if it takes a lot of time to modify, you can leave it for now)?

PR: Modify X Commit: Modify X. This is done by adding a new HTTP handler.

Ideally, we want to allow Commit message contain additional explanations.

nayuta-ai commented 4 months ago

@ryuji0123 The commit message has been modified to include additional explanations. Below is the test result: