search

okuda-seminar / Twitter-Clone

0 stars 0 forks source link

[go/users] Add test for Unfollow #344

Closed katsurada1 closed 4 months ago

katsurada1 commented 4 months ago

Issue Number

342

Implementation Summary

Same with the title.

Scope of Impact

TestUnfollow tests the unfollow method.

Particular points to check

If there is an overlooked point to be changed and the changes are proper.

Test

None

Schedule

Anytime

katsurada1 commented 4 months ago

@ryuju0911 I changed the Unfollow method to return an appropriate error message if the follow relationship does not exist, and the DeleteFollowship method to return sql.ErrNoRows if the follow relationship you are trying to delete does not exist. I also added TestUnfollow.

Please review my code.

ryuju0911 commented 4 months ago

I think the change to Unfollow API is beyond the scope of this issue. Let's focus on adding a test here. BTW, we need further discussion about returning sql.ErrNoRows because it is intended to be returned by sql.QueryRow.

katsurada1 commented 4 months ago

@ryuju0911 I made an issue and wrote TODO regarding the addition of an error to the Unfollow function when trying to unfollow an unfollowed or non-existent user. I have only made modifications to the files related to the tests.

Please review my code.