Closed TakayaShirai closed 2 months ago
BTW, you need to write which point you want reviewers to double-check in Particular points to check
. The current one sounds like Notes
.
BTW, you need to write which point you want reviewers to double-check in
Particular points to check
. The current one sounds likeNotes
.
I updated the Particular points to check
. Please check if the current one is appropriate.
Issue Number
https://github.com/okuda-seminar/Twitter-Clone/issues/400
Implementation Summary
I made it enable to display SideMenu with a custom modal animation and without
AppRootViewController
.Previously,
AppRootViewController
was used only to displaySideMenuView
while linking it withMainRootViewController
, but by using this Package, the functionality can now be achieved using onlyMainRootViewController
andSideMenuView
.This makes it easier to understand the view hierarchy intuitively and the code simpler.
Scope of Impact
You can see the SideMenu by dragging horizontally or tapping the user icon on the upper left of the view.
Particular points to check
Please check if adding
view.backgroundColor = .systemBackground
in NotificationsSettingsViewController.swift and SettingsHomeViewController.swift is appropriate. These are added because the top of the screens became black according to this refactoring. Also, I'm reporting this just in case, though there is still a view transition speed problem betweenAppRootViewController
and eachSideMenu
view, I decided to leave that problem as it is and fix that problem in https://github.com/okuda-seminar/Twitter-Clone/issues/409.Reference
https://github.com/user-attachments/assets/19628a12-d421-421a-8f5f-2fbdbd431725
Schedule
Until 8/31.