Unable to name cards that do not appear in the Supply

[GoogleCodeExporter]

What steps will reproduce the problem?
1. In a game with Shelters, buy a Doctor.
2. Play Doctor.

What is the expected output? What do you see instead?
You are not able to name any of the Shelters, but you should be able to -- the 
card does not specify that you can only name cards in the Supply. Similarly, 
you are unable to name Mercenary, Spoils, or Madman. This bug also applies to 
Journeyman.

What version of the product are you using? On what operating system?
Latest Guilds branch, Android 4.2.2, Samsung S4

Please provide any additional information below.
Seems like an easy fix would be to use the "pick a card in your deck" UI that 
is currently used for Wishing Well, Mystic, etc. Although then you run into the 
case where you play Doctor and you don't want to trash anything in your deck 
(e.g. you've used Doctor to trash all the Estates and Coppers, but your Herald 
hits Doctor, forcing you to play it).

Original issue reported on code.google.com by wesc...@gmail.com on 20 Oct 2013 at 4:52

[GoogleCodeExporter]

To be clear - are you building off of Guilds, trunk, or multiplayer?  I have 
actually changed the behavior of Wishing Well and those others in the 
multiplayer branch to just let you pick a card from the supply, not realizing 
that this was an issue.  So in asking this question I'm trying to figure out if 
I introduced this bug, or if it was already there.  If I introduced it, it 
should be easy to fix; otherwise, it'll be a slightly more complicated fix in 
the game engine.

Original comment by drai...@gmail.com on 21 Oct 2013 at 5:29

[GoogleCodeExporter]

I'm building off Guilds. I actually filed an issue a while back asking for the 
change you described, but I was convinced the current way is better. See Issue 
544 and Issue 461.

Original comment by wesc...@gmail.com on 21 Oct 2013 at 6:43

[GoogleCodeExporter]

Ok, that history is good to know.  I changed the behavior because it was easier 
to implement with multiplayer, but now that I know the problems with it, I'll 
change it back.  It shouldn't be that much work to fix Doctor and Journeyman 
while I'm at it.

Original comment by drai...@gmail.com on 21 Oct 2013 at 1:29

• Changed state: Accepted

[GoogleCodeExporter]

This should be fixed in r847, though I admit to not having tested it.  At least 
similarly coded cards work, so this should hopefully also work.  Reopen the 
ticket it if doesn't, and I'll look at it again.

Original comment by drai...@gmail.com on 29 Oct 2013 at 8:45

• Changed state: Fixed