search

okuramasafumi / alba

Alba is a JSON serializer for Ruby, JRuby and TruffleRuby.
https://okuramasafumi.github.io/alba/
MIT License
934 stars 43 forks source link

Add ostruct as gemspec dependency to be prepared for ruby 3.3.5. #386

Closed wuarmin closed 13 hours ago

wuarmin commented 1 day ago

Hey,

with this fix, we supress the warning: 

/usr/local/bundle/gems/alba-3.2.0/lib/alba.rb:4: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.

best regards

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.82%. Comparing base (54aebe6) to head (9670520). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #386 +/- ## ======================================= Coverage 99.82% 99.82% ======================================= Files 14 14 Lines 574 574 Branches 139 139 ======================================= Hits 573 573 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

okuramasafumi commented 1 day ago

@wuarmin Good catch, thank you! Although OpenStruct is used in Alba, it's used for just a tiny peace of code and I'd like to remove it.

okuramasafumi commented 1 day ago

@wuarmin Could you rebase this branch to main branch? That should fix CI. Also, please squash two commits into one since the second commit is just a fix of the first one.