search

okwasniewski / react-native-bottom-tabs

Native Bottom Tabs for React Native
https://okwasniewski.github.io/react-native-bottom-tabs/
MIT License
619 stars 24 forks source link

Adding freezeOnBlur for android and iOS #113

Open shubhamguptadream11 opened 2 weeks ago

shubhamguptadream11 commented 2 weeks ago

Solves this: https://github.com/okwasniewski/react-native-bottom-tabs/issues/71

Adding freezeOnBlur property.

shubhamguptadream11 commented 2 weeks ago

Hey @okwasniewski,

I've implemented the freezeOnBlur property, following the same approach as in the JS bottom tabs. I've tested it on Android, both with enableFreeze() globally and by overriding it through options for individual tabs. Currently, I’m testing this on iOS to ensure everything works smoothly there as well.

Meanwhile, feel free to review the PR when you have a chance.

Thanks!

okwasniewski commented 2 weeks ago

I got instant crash on new arch when going into the example

CleanShot 2024-11-03 at 18 57 55@2x

shubhamguptadream11 commented 2 weeks ago

@okwasniewski Fixed the iOS crash and tested it on Old and New arch for both platforms. Seems to be working fine now with react-native-screens enabled and disabled.

okwasniewski commented 1 week ago

Hey, sorry for the delay on review of this PR, I'm trying to get in touch with someone from react-native-screens team to check if we will be okay without the ScreenContainer wrapper on iOS.