search

okwasniewski / react-native-bottom-tabs

Native Bottom Tabs for React Native
https://okwasniewski.github.io/react-native-bottom-tabs/
MIT License
628 stars 24 forks source link

Compatibility with `expo-image` on Android #141

Closed okwasniewski closed 1 week ago

okwasniewski commented 1 week ago

Currently due to both libraries using Glide (native dependency) and including their own AppGlideModule its not possible to use them together.

To solve this we need to probably remove AppGlideModule from both Bottom Tabs and Expo Image and generate this file (one per project).

Goal of this issue is to track the compatibility.

ajanuar commented 1 week ago

Hi @okwasniewski , I've tested 0.5.1 and still facing this issue.

Type com.bumptech.glide.GeneratedAppGlideModuleImpl is defined multiple times: /Users/pintu/Documents/pintu/pintu-react-native/packages/apps/node_modules/react-native-bottom-tabs/android/build/.transforms/307235aa7405415dc1e7321c93ad28a3/transformed/classes/classes_dex/classes.dex, /Users/pintu/Documents/pintu/pintu-react-native/packages/apps/node_modules/expo-image/android/build/.transforms/13f42b336286962acdd6a9a2e03e1e73/transformed/classes/classes_dex/classes.dex
okwasniewski commented 1 week ago

@ajanuar I'm trying to get in touch with Expo team to get this working, unfortunately it requires action on both expo image side and Bottom Tabs

okwasniewski commented 1 week ago

@ajanuar Can you check with 0.5.2?

ajanuar commented 1 week ago

@okwasniewski now it's working well. thanks!