okwasniewski / react-native-bottom-tabs

Native Bottom Tabs for React Native
https://okwasniewski.github.io/react-native-bottom-tabs/
MIT License
616 stars 24 forks source link

SDWebImage compatibility with @d11/react-native-fast-image #154

Open hamdij0maa opened 1 day ago

hamdij0maa commented 1 day ago

Before submitting a new issue

Bug summary

[!] CocoaPods could not find compatible versions for pod "SDWebImage": In Podfile: RNFastImage (from ../node_modules/@d11/react-native-fast-image) was resolved to 8.8.1, which depends on SDWebImage (~> 5.18.7)

react-native-bottom-tabs (from `../node_modules/react-native-bottom-tabs`) was resolved to 0.6.0, which depends on
  SDWebImage (>= 5.19.1)

Library version

0.6.0

Environment info

react native cli

Steps to reproduce

Install the lib with react-native-fast-image installed

Reproducible sample code

[!] CocoaPods could not find compatible versions for pod "SDWebImage":   In Podfile:     RNFastImage (from `../node_modules/@d11/react-native-fast-image`) was resolved to 8.8.1, which depends on       SDWebImage (~> 5.18.7)      react-native-bottom-tabs (from `../node_modules/react-native-bottom-tabs`) was resolved to 0.6.0, which depends on       SDWebImage (>= 5.19.1)
okwasniewski commented 1 day ago

Hey @hamdij0maa,

Thanks for opening the issue, it looks like both @d11/react-native-fast-image and bottom tabs depend on the same native library.

It looks like RNFastImage requires an older version of the library to work, probably would be best to bump the version in RNFastImage and allow for a wider range (this library allows for >= 5.19.1 not a single version ~> 5.18.7).

I think react-native-fast-image should update the version range (as it's so explicit it allows for only one version), can you open an issue in their repository?