okwasniewski / react-native-bottom-tabs

Native Bottom Tabs for React Native
https://www.npmjs.com/package/react-native-bottom-tabs
MIT License
284 stars 9 forks source link

Tab bar looks strange on Android (dark mode?) #40

Open fredrikburmester opened 2 days ago

fredrikburmester commented 2 days ago
Screenshot 2024-10-13 at 13 43 10

Code:

<NativeTabs.Screen
        name="(libraries)"
        options={{
          title: "Library",
          tabBarIcon: ({ color, focused, size }) =>
            require("@/assets/icons/server.rack.png"),
        }}
      />
okwasniewski commented 1 day ago

Hey, thanks for opening the issue.

This is indeed an issue with dark mode. The styles of the TabBar on Android are dictated by styles.xml file (Native project file).

We will probably need Expo Config plugin to allow for easy changes. Have you modified this file in any way? Also is the TabBar white if you switch to white mode?

fredrikburmester commented 1 day ago

I have not modified the styles.xml at all. Would be great with an Expo config plugin.

I will test changing to light mode later today and report back.

a-eid commented 18 hours ago

@okwasniewski there is no way to pass colors as props ?

fredrikburmester commented 10 hours ago

I found that changing color props did nothing. Have not had time to test light mode yet.

okwasniewski commented 9 hours ago

@okwasniewski there is no way to pass colors as props ?

Not at the moment, this issue #11 is tracking the progress

okwasniewski commented 7 hours ago

Issue tracking expo config plugin: #48