search

okwasniewski / react-native-bottom-tabs

Native Bottom Tabs for React Native
https://www.npmjs.com/package/react-native-bottom-tabs
MIT License
284 stars 9 forks source link

fix: add react-navigation export to package.json #44

Open natew opened 18 hours ago

natew commented 18 hours ago

Yo! Awesome work with this library, was testing it out with onestack.dev and this makes things a bit easier to set up with Vite.

okwasniewski commented 9 hours ago

Hey, thanks for opening the PR!

Do you think this react-navigation/package.json is now also required?

https://github.com/okwasniewski/react-native-bottom-tabs/blob/main/react-navigation/package.json

Im not sure if both of them are needed

natew commented 6 hours ago

I’m not sure I think that may be for metro or older node - what I’ve typically done is just added a new file like react-native.js at the root that they will use and that file just re-exports things from the right dist folder. I can link to that pattern later when I’m back from dinner.