Add tests & update instructions.

[jorgebucaran]

• Add tests with 100% coverage.
• Improve instructions, match style used in hyperapp docs.
• Use prettier to format code.

cc @okwolf.

[okwolf]

@jbucaran any reason for using Upper Case for Logger? It looks like it should be a component. Since it's a function, I'm used to going with lower case.

[jorgebucaran]

@okwolf In hyperapp we don't use classes / constructors, so we don't generally need to follow that convention and it's also how the Router works too.

The module exports a function so you can always...

import logger from "hyperapp-router"

...if you want though.

[okwolf]

@jbucaran I guess it matters more for the global for use in browsers.

[jorgebucaran]

@okwolf React's global is also React and ReactDOM. It also looks good, but I guess that's a matter of taste too.

[okwolf]

@jbucaran should the global for Hyperapp be Hyperapp then? 😉

[jorgebucaran]

@okwolf Yes, I think so. That should be the way to go. Or not, maybe only mixins?

/cc @MatejMazur @Zaceno @Jamen @Andyrj @Selfup

[okwolf]

@jbucaran is upper case used by many mixins in the wild outside of Hyperapp? I see some examples to the contrary.

[jorgebucaran]

@okwolf Most modules are a single default export so if the exported global is lowercase or uppercase, I don't mind.

But in the router, we export two things and the default export is actually { Router, Link }. Link is a component, and those must be uppercase. The Router is mixin, not a component, so it doesn't really matter. I made it uppercase because I felt it was more aesthetically pleasing though, but I can change my mind if that's how people like it.

[jorgebucaran]

@okwolf Let's go with lowercase then. I'll update the router later.

[okwolf]

@jbucaran thanks for the updates. I'm ready to merge if you're happy.

[jorgebucaran]

👍