okx / go-wallet-sdk

Multi-chain golang signature sdk, supports bitcoin, ethereum, aptos, cosmos, etc.
MIT License
363 stars 130 forks source link

Return value error #54

Closed albbm closed 3 months ago

albbm commented 3 months ago

In the latest version of btcec/v2/ecdsa, SignCompact has removed the error return value and only returns a value

https://github.com/btcsuite/btcd/commit/e5d15fddb9c486dfe382bc95dc38d2fd247813bf

image

Source code needs to be modified

image
evieyee commented 3 months ago

Thank you very much for pointing out this issue. The current code references a version of btcsuite/btcd that is not the latest. You can try modifying it to reference an earlier version. In the future, we will improve the go.mod file to make the build process easier.

luyishisi commented 3 months ago

Thank you for your attention to and use of the OKX open-source Go SDK. The error you encountered stems from your local environment not using the btcd version specified in the original go.mod file of the Git repository. Please revert to the specified version to eliminate this error.

As for the overall version upgrade of the dependencies in this repository, we will wait for the official stable release and comprehensively evaluate the necessity of the upgrade before proceeding.

Thank you again for your feedback.