search

okx / go-wallet-sdk

Multi-chain golang signature sdk, supports bitcoin, ethereum, aptos, cosmos, etc.
MIT License
363 stars 130 forks source link

Incompatibility with ecdsa.SignCompact return values #71

Closed Shinku1014 closed 1 week ago

Shinku1014 commented 1 week ago

It seems that the ecdsa.SignCompact function in btcsuite has recently changed its implementation, which makes an incompatibility at okx/go-wallet-sdk/coins/bitcoin@v0.0.3/message.go:537:14:sig, err := ecdsa.SignCompact(w.PrivKey, messageHash, true)

Could we kindly request an update to the code to align with the new changes? Thank you for your attention to this matter.

luyishisi commented 1 week ago

When running this SDK, please use the specified dependent library version. We will make a comprehensive assessment before upgrading the latest version changes.

Shinku1014 commented 1 week ago

When running this SDK, please use the specified dependent library version. We will make a comprehensive assessment before upgrading the latest version changes.

Thank you for the guidance. I have resolved the issue following your advice.