search

okyeron / OMX-27

157 stars 38 forks source link

Encapsulate seq state: Take 2 #32

Closed catkins closed 2 years ago

catkins commented 2 years ago

Same changes as #27 but rebased onto main now that #28 has been merged

Re-arranging pattern state and settings into same object tree. May make things a bit more Object Oriented, such that Pattern can handle some logic itself. No functional changes, just shuffling around some code (pure refactoring)

Some of the motivation: http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#i2-avoid-non-const-global-variables

Note: Best reviewed in split mode, and hiding whitespace diffs. https://github.com/okyeron/OMX-27/pull/32/files?diff=split&w=1

There's plenty more that could be done to move actual logic into the sequencer class, but I think that's best left to future PRs.

okyeron commented 2 years ago

sequencer.h line 52 This needs to be 6 for 64 steps.

I posted a review for that above, but can't figure out how to link back to it.