search

ol-iver / denonavr

Automation Library for Denon AVR receivers.
MIT License
176 stars 67 forks source link

Import all 3313 IR commands; test a mute toggle. #103

Closed JPHutchins closed 4 years ago

JPHutchins commented 5 years ago

It is speculation, but so far we know that these commands work for AVR X4400H (2017), AVR X1500H (2018), and the source document is for AVR 3313 (2012), so they may be the most compatible set of codes that we have.

It would not be my intention to write many methods such as the mute_toggle in this PR, but rather to make available the general purpose method send_post_ir that allows the user to send generic IR commands. This allows the implementer of the library, including Home Assistant, to add specific IR commands to suit their needs without bogging down this library with more API variations than it already has. To this end, import denonavr.ir_code as ir gives the user or developer access to a library that may allow them to achieve their specific goals.

Eventually these codes may become outdated and we can continue with the XML command API or some other variation.

Thank you to @bendavid for taking the time to verify that these codes work via the iPhoneAppDirect.xml endpoint and providing a link to the exhaustive list!

Cheers, J.P.

ol-iver commented 4 years ago

Thanks for implementing this @JPHutchins . I'm not able to test it, because apparently my Denon does not support those commands. Could you please remove the PDF File from docs folder, because it looks like a part of a Denon manual and should not been published here.

Edit: my Denon AVR-X4100W is supporting the commands, but the HTTP request can be handled correctly only when using GET instead of POST. Please see comments below.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.