search

ol-iver / denonavr

Automation Library for Denon AVR receivers.
MIT License
176 stars 67 forks source link

fix getting receiver name for avr-x-2016 #142

Closed starkillerOG closed 4 years ago

ol-iver commented 4 years ago

Please see my comment. We should add multiple zone support to config flow instead.

starkillerOG commented 4 years ago

@scarface-4711 I see your point. However if using self._get_zone_name the entities will be called "Main Zone", "Zone2", "Zone3" which is also not ideal...

What about combining self._get_receiver_name and self._get_zone_name to get "{FriendlyName} Main Zone", "{Friendlyname} Zone2" and "{Friendlyname} Zone3"?

ol-iver commented 4 years ago

Those are just the default names. Zones can be renamed on the config page of the receiver. My Main Zone is called "Wohnzimmer".

starkillerOG commented 4 years ago

Please see my comment. We should add multiple zone support to config flow instead.

multiple zones are supported and tested by the config flow

starkillerOG commented 4 years ago

Those are just the default names. Zones can be renamed on the config page of the receiver. My Main Zone is called "Wohnzimmer".

fair point, so maybe not change lines 473 to 475, but the rest is still valid. The option to get the FriendlyName for avr-x-2016 receivers schould still be merged

ol-iver commented 4 years ago

But the method is not called anywhere for avr-x devices

ol-iver commented 4 years ago

I checked how the zone names for the other device types are created. This is simply FriendlyName + Zone2 or Zone3. This zone stuff for avr-x-2016 was overkill. You are able to change the entity name in home-assistant anyway. In the version 0.9.3 now every device shares the same naming convention.