Check for param.text before modifying it

ol-iver / denonavr

Automation Library for Denon AVR receivers.

MIT License

176 stars 67 forks source link

Check for param.text before modifying it #171

Closed JPHutchins closed 3 years ago

JPHutchins commented 3 years ago

Fix for https://github.com/scarface-4711/denonavr/issues/170

If param.text for dynamiceq is None then set self.dynamiceq to None (not False). This is consistent with what will happen with the other attributes when their respective param.text is None: MULTI_EQ_MAP.get(param.text)

ol-iver commented 3 years ago

@JPHutchins thanks 😄 Changed it slighthly different in this commit https://github.com/scarface-4711/denonavr/commit/b073203039f1bf2a4b45cd48fd4e9ce298f1f34d In you fix the self.dynamiceq would be also None if the receiver would return an integer 0

Additionally I checked for a no None value a couple of lines later https://github.com/scarface-4711/denonavr/blob/master/denonavr/audyssey.py#L119