search

ol-iver / denonavr

Automation Library for Denon AVR receivers.
MIT License
176 stars 67 forks source link

Add treble_up, treble_down, bass_up, bass_down #193

Closed MarBra closed 3 years ago

MarBra commented 3 years ago

I have added treble_up, treble_down, bass_up, bass_down and a update_tonecontrol method.

MarBra commented 3 years ago

Thanks @MarBra There is just a little remark about running updates after up/down commands.

Thanks for the review @scarface-4711 I have added the update call to the generic set command. Is this OK for you or shall I add it to the methods itself?

ol-iver commented 3 years ago

Thanks @MarBra There is just a little remark about running updates after up/down commands.

Thanks for the review @scarface-4711 I have added the update call to the generic set command. Is this OK for you or shall I add it to the methods itself?

@MarBra I would prefer it just in the up/down methods themselves, that the update method is just called when it is absolutely neccessary. This follows the way the other interfaces are designed.

MarBra commented 3 years ago

Thanks @MarBra There is just a little remark about running updates after up/down commands.

Thanks for the review @scarface-4711 I have added the update call to the generic set command. Is this OK for you or shall I add it to the methods itself?

@MarBra I would prefer it just in the up/down methods themselves, that the update method is just called when it is absolutely neccessary. This follows the way the other interfaces are designed.

Alright 👍 Just pushed a new commit.

ol-iver commented 3 years ago

thank you 😄