olacabs / jackhammer

Jackhammer - One Security vulnerability assessment/management tool to solve all the security team problems.
https://jch.olacabs.com/userguide
Other
719 stars 162 forks source link

Improvements on Network scanning and Scan Uploading #27

Open rongutierrez opened 7 years ago

rongutierrez commented 7 years ago

It looks like you only allow a single IP address when performing Network scans. This won't scale much at all..

Additionally, when a new Network project is created and a nessus scan is uploaded all of the findings within the Nessus scan would be associated with the target ip used whenthe scan project was created instead of the actually reported IPs within the Nessus scan results. In general, I have the following proposals for making this a better solution

roelstorms commented 7 years ago

Managing network targets as mentioned above via ranges (look an nmap for a good synthax to support)

Also, from this infra scan the ability to define the service running on the port and have service specific scanners that can be launched at the click of a button. You scan 192.168.1.0-255 and have 10 hosts with port 80 open. Then you want to launch a web app scan on these hosts automatically.

Love the project btw!

shadsidd commented 7 years ago

@rongutierrez completely agreed with you and WIP on that. The V2 of jackhammer would solve the shortcomings you mentioned and provide tons of additional feature across all kind of scanner with support for docker scanning. It would also have tools segregated so anyone could modify tools without causing a problem to any other tool and the single orchestrator will take care of self-healing and rolling back in case there is a problem. Your current feature request are not major to fix but I would request you to hold on for a couple of weeks for the V2 that would be a major bump to the current architecture .

@roelstorms As I mentioned above the V2 would run all the scan in parallel and we wont need Owasp Pipeline and it would have feature to upload files containing list of ips, mass-scanning etc. And Reporting format would be revamped a bit for better showcasing of results.

Hope that helps :)